Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: (PSKD-434) (PSKD-702) AWS no longer has a default storage class with K8s 1.30 #303

Merged
merged 3 commits into from
Sep 10, 2024
Merged

fix: (PSKD-434) (PSKD-702) AWS no longer has a default storage class with K8s 1.30 #303

merged 3 commits into from
Sep 10, 2024

Conversation

dhoucgitter
Copy link
Member

@dhoucgitter dhoucgitter commented Sep 6, 2024 •
edited
Loading

Changes required:

From https://docs.aws.amazon.com/eks/latest/userguide/kubernetes-versions-standard.html

Starting with 1.30, Amazon EKS no longer includes the default annotation on the gp2 StorageClass resource applied to newly created clusters. This has no impact if you are referencing this storage class by name. You must take action if you were relying on having a default StorageClass in the cluster.

The changes made here are helping to mitigate issues arising from the last sentence above.

Testing:

Internal testing of the proposed changes have been positive.

@dhoucgitter dhoucgitter added the bug Something isn't working label Sep 6, 2024
@dhoucgitter dhoucgitter self-assigned this Sep 6, 2024
undr-rowr
undr-rowr reviewed Sep 6, 2024
View reviewed changes
main.tf Outdated Show resolved Hide resolved
@dhoucgitter dhoucgitter merged commit 877367b into staging Sep 10, 2024
4 checks passed
@dhoucgitter dhoucgitter deleted the PSKD-434 branch September 10, 2024 15:43
@dhoucgitter dhoucgitter changed the title (PSKD-434) AWS no longer has a default storage class with K8s 1.30 (PSKD-434) (PSKD-702) AWS no longer has a default storage class with K8s 1.30 Sep 10, 2024
@dhoucgitter dhoucgitter changed the title (PSKD-434) (PSKD-702) AWS no longer has a default storage class with K8s 1.30 fix: (PSKD-434) (PSKD-702) AWS no longer has a default storage class with K8s 1.30 Sep 19, 2024
@dhoucgitter dhoucgitter mentioned this pull request Sep 19, 2024
Merged
dhoucgitter added a commit that referenced this pull request Sep 19, 2024
@dhoucgitter
(PSKD-434) AWS no longer has a default storage class with K8s 1.30 (#303
1c01565 
)

* AWS no longer has default storage class with K8s 1.30

* Update patch SC comment

* Add internal ticket reference for aws-ebs-csi-driver update work
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joboon joboon joboon approved these changes

@saschjmil saschjmil saschjmil approved these changes

@kylhia kylhia Awaiting requested review from kylhia

@undr-rowr undr-rowr Awaiting requested review from undr-rowr

Assignees

@dhoucgitter dhoucgitter

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dhoucgitter @undr-rowr @saschjmil @joboon